webpack it!

Question

webpack it!

Closed this issue 8 years ago · 12 comments

Hey!!! Sean from the webpack team! Would you take a PR if provided to bundle the assets on both main and renderer portions of this application?!

Pros: startup and render performance could be significantly faster!

Cons: have a build step?

I've been looking for a great case study for electron performance and app migration and I think this would be a great one.

Thanks!
Sean - webpack team

nicholas-ochoa commented 8 years ago

Sure

Answer 1 · 2018-02-07T06:02:53.000Z

I would be willing to setup a CI build in appveyor for your webpack build step.

Answer 2 · 2018-02-07T21:48:18.000Z

In hopes of not biting off more then I can chew, if it would be beneficial to allow a broader collaboration for this, and given a PR would be acceptable, I can create (or update this issue) to include a spec like set of requirements and isolated tasks for contributors to tackle. That way this work isn't just hung up by myself (if it turns out to be a larger task).

Answer 3 · 2018-02-07T22:31:46.000Z

I'd be interested in helping out with this, I've been looking for a reason to learn about how webpack is used but haven't found the right project so it'd be a great learning experience.

…

On Feb 7, 2018 9:48 PM, "Sean Larkin" ***@***.***> wrote: In hopes of not biting off more then I can chew, if it would be beneficial to allow a broader collaboration for this, and given a PR would be acceptable, I can create (or update this issue) to include a spec like set of requirements and isolated tasks for contributors to tackle. That way this work isn't just hung up by myself (if it turns out to be a larger task). — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#17 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACKQrj1nwM9qDipdi6Pg5S49bRacEppiks5tShokgaJpZM4R8LOh> .

Answer 4 · 2018-02-08T07:52:28.000Z

~~Can you please explain to the layman (or if you have any links handy) why using webpack with electron and serving the code through a server instead of consuming it directly would be faster?~~

~~I've struggled to understand this ever since I first switched to electron-compile and then directly to babel using babel --watch to auto-transform on changes to the source.~~

Answer 5 · 2018-02-08T13:02:12.000Z

@whphhg I didn't think that webpack required you to serve it through a server? It can be used to just compress the code into single files can't it? Maybe I'm misunderstanding what it does?

Answer 6 · 2018-02-08T14:50:16.000Z

@cursorial you are correct, I have misunderstood how it's used all this time. The server is only used for HMR during development and in production it loads the local entry point.

I've found these resources to be useful:

Answer 7 · 2018-02-09T11:01:45.000Z

Did somebody pick this up already? I have some spare time tonight / this weekend and I want to look into this.

Answer 8 · 2018-02-09T11:55:47.000Z

I haven't touched it yet myself, I'd just go for any issues that @rage8885 hasn't assigned to himself unless someone has commented that they're working on it.

…

On Feb 9, 2018 11:01 AM, "DevNebulae" ***@***.***> wrote: Did somebody pick this up already? I have some spare time tonight / this weekend and I want to look into this. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#17 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACKQrn_xN82p0Vfapa7mgk4-KYpFvvUxks5tTCWagaJpZM4R8LOh> .

Answer 9 · 2018-02-10T23:28:35.000Z

Hi finally have a bit of time to split some things up here! I'm going to pull the code down first and do a little assessment before getting started.

Answer 10 · 2018-02-11T11:04:06.000Z

@TheLarkInn I discovered an issue while trying to implement this feature, check #32 to see the issue I ran into, but it is being worked on.

Answer 11 · 2018-02-22T17:48:07.000Z

The re-write is now using webpack/eslint, closing this one.