nick-fields/private-action-loader

Support for other Action types other than nodejs

ohad-alike opened this issue · 2 comments

ohad-alike commented

I was trying to use this for a Docker based Action, Docker based actions doesn't have action.runs.main member.
After going through the code, I could see that you execute on action.ts line 88:
await exec.exec(node ${join(actionPath, action.runs.main)});

Is this correct that right now it only supports nodejs based actions?
If so, it should be mentioned somewhere in the docs.
Thanks.

nick-invision commented

Sorry about that, I should have been more explicit in the limitations section of the readme. I specify javascript, but I should further clarify that to say nodejs.

ohad-alike commented

Hi nick, thanks,
I would put it higher on the README page, it's sufficient as it is right now but maybe should be more visible.
I would also consider changing the name of the Action to running private JS actions.
Thanks.