panicked at ytmapi-rs/src/parse/artist.rs:169:56: not yet implemented

Question

panicked at ytmapi-rs/src/parse/artist.rs:169:56: not yet implemented

Closed this issue 4 months ago · 3 comments

rkratky commented 4 months ago

The error is shown on a blank screen (i.e. the UI disappears and is replaced by this text only) following:

Search for 'classical music'.
Select one of the following:
- Deutsche Grammophon - DG
- Warner Classics
- Naxos Music
- Sony Classical

The program doesn't recover, though pressing Enter brings up a mangled, non-responsive part of the UI:

Answer 1 · 2024-08-30T12:33:22.000Z

Btw, playback continues uninterrupted.

Answer 2 · 2024-08-30T13:40:47.000Z

Welp, that's the first time someone's triggered that branch in GetArtistQuery it seems. Think I know what needs fixing. Could be an opportunity to improve the panic handling too.

Answer 3 · 2024-08-30T15:20:29.000Z

Resolved in #161, panic code should be more robust now too, you should no longer get a glitchy crash if you find another panic. Note; these 'artists' will correctly return no results, they don't have any albums.