nickbabcock/Farmhash.Sharp

Make the Hash32 and Hash64 overloads which take a byte* public

NickStrupat opened this issue · 3 comments

NickStrupat commented

Hi Nick,

I'm wondering what you think of exposing the unsafe overloads for Hash32 and Hash64 methods. I'd rather not create a bunch of byte[] when I'm calling it a lot in my already unsafe code :)

Farmhash.Sharp/Farmhash.Sharp/Farmhash.cs

Line 123 in b49de64

private static unsafe uint Hash32(byte* s, uint len)

Farmhash.Sharp/Farmhash.Sharp/Farmhash.cs

Line 527 in b49de64

private static unsafe ulong Hash64(byte* s, uint len)

Thanks,
Nick

nickbabcock commented

Makes sense. Feel free to make PR or I can do it. I'll release an update today.

  • 🎉1
nickbabcock commented

I pushed 0.4 to NuGet. Give it a whirl!

  • 🎉1