nickbclifford/dotnetdll

Incorrect writing of generic parameters

FoLZer opened this issue · 2 comments

FoLZer commented

Hey,

I'm not sure if that's a bug in my implementation using your library or it's actually in the library but it seems like this line should be build_generic!(t.generic_parameters, TypeDef(idx + 1)); instead in order to skip the class, as it's done in several other places.

Without changing the line, it moves every generic parameter up by 1 in dll making them incorrect. (If this is indeed a mistake, it should also affect the security but I've not checked that one yet)

Hey, thanks for reaching out! I can indeed reproduce an issue with type generics, so this is definitely dotnetdll's fault - working on a bugfix and test right now.

Fixed in 4a08699, thanks for bringing this to my attention!