nicoknoll/MarkupSEO

Incompatibility with PW3.0.4X

Opened this issue · 8 comments

Hi Nico

As per the forums, a few users reporting issues with upgrades to PW3.0.4X
In my case the META tags don't render at all.
I'm using <?php echo $page->seo->render;?>

Any idea when you could look at this?

It worked fine with 3.0.44, but then with 3.0.45 it causes an error.

Tracy Debugger reports the following:
PHP Notice: Trying to get property of non-object in .../wwwroot/site/modules/MarkupSEO/MarkupSEO.module:127

I wonder if it is related to the new changes in Hooks processwire/processwire@953ca72 ?

If I debug that line 127 bd($this->page); show's the page object but doesn't show any seo information attached to it.

Hey @gmclelland
I'm not sure. Not too familiar with the inner workings of hooks etc.
Wondering if this is an issue for here or for the PW repo?

Not sure, I'm new to Processwire and hooks as well.

I think there's a PW core change that is causing this. $this->addHookProperty seems not working in this module anymore.

Changing this line seem to work (only trial and error):

//$this->addHookProperty("Page::seo", $this, 'hookFrontendPage');
$this->wire('page')->addHookProperty("seo", $this, 'hookFrontendPage');

Fixed 15 minutes ago :)

Good news! Thanks for the heads up @rolandtoth.

blynx commented

Seems to be fixed in ProcessWire:

https://processwire.com/talk/topic/8007-markupseo-the-all-in-one-seo-solution-for-processwire/?do=findComment&comment=135414

edit:
ah oh - rolandtoth already linked that.
sry