nicolaslopezj/react-meteor-data

componentWillMount & componentWillUpdate Deprecated in React 16

Closed this issue · 1 comments

Hi, thanks for sharing this great package.

Reproduce deprecation warnings with 3 commands:

curl https://install.meteor.com/ | sh
cd /tmp; meteor create --react foo
cd foo; meteor

Warnings produced by react 16 in the automatically generated package.json

    "react": "^16.9.0",
    "react-dom": "^16.9.0",

image

Finding offending code:

grep -rn ~/.meteor -e "componentWill\(Mount\|Update\)"

~/.meteor/packages/react-meteor-data/.0.2.16.w4vu92.v54d++os+web.browser+web.cordova/os/ReactMeteorData.jsx:127:  componentWillMount() {
~/.meteor/packages/react-meteor-data/.0.2.16.w4vu92.v54d++os+web.browser+web.cordova/os/ReactMeteorData.jsx:134:  componentWillUpdate(nextProps, nextState) {

But I couldn't find ReactMeteorData.jsx or componentWillUpdate in this repo. Only
https://github.com/orionsoft/react-meteor-data/blob/d40a7eb4d4fe807d029be9aca9c5d8b2d05f4b04/with-method-data.js#L21

So I'm not sure if this is the right place to post this.
If this is not the correct place for this issue, please let me know where I should post this issue.

Thanks!

Looks like this was the correct place to post:
meteor/react-packages#252