nightscout/chrome-uploader

Config changes not read to config datastructure.

Closed this issue · 1 comments

Hi Brian,

I think I found a bug: When changing the settings (for high and low), the UI doesn't update anymore. The local config structure is not modified (not read from the chromestorage). Restarting the whole programme does help, as it reads the structure from the chrome storage.

While I do not understand the config.js in total on first glance (because of define/require.js I think), I think I part of the problem is:
The Listener registered in line 23 (and following) of config.js does not execute the loop, even though ( "config" in changes) == true:
for (var property in changes[config].newValue) {...}

Do you have a solution? Loading the whole config, not just the changes?

(I'm still not convinced that ther cannot be overlaps with "issaving" - but then it shouldn't have reached the loop in the fist place).

Thank you! It seems to work now as I expected. I'll close this issue.