nightsky30/koikoi

Refactor code

Opened this issue · 1 comments

nightsky30 commented

Refactor code:

  • Remove redundant resources from .qrc files/folders??
  • Incorporate more checks??
  • Dbl check vars are initialized in member var initialization list
  • Re-evaluate member access
  • Dbl check includes
  • Dbl check use of pointers
  • Fix remaining warnings (casting, unused vars, etc)
  • Look at repeated lines of code/logic, refactor into loops
  • Remove old print functions
  • Remove redundant calls
  • Comment cleanup
  • Fix uniformity with button detection and regex usage

commit 8d5d963
commit 49e0d65
commit a3d802d
commit bd4bc80
commit 02802e5
commit 8fcb000
commit 861374c

nightsky30 commented

Though it does not cause a bug because the card numbers do not reach double digits...Use regex uniformly with getting sender button numbers. Still need to fix that in these two places:

koikoi/src/koikoi.cpp

Line 1802 in d414f1c

QChar buttonNum = (buttonName.at(buttonName.size()-1));

koikoi/src/koikoi.cpp

Line 1842 in d414f1c

int cardNum = buttonName.at(buttonName.size()-1).digitValue();