nikic/iter

Add typehints

SamMousa opened this issue · 1 comments

SamMousa commented

Since PHP7.1, which is required in composer.json the iterable type hint is supported.

Would you:

  1. Accept a PR that makes the parameters to functions that take iterables typed.

Or, if not 1:

  1. Accept a PR that adds iterable as an option in the PHPDoc (since array|Traversable does not include iterable).

?

jvasseur commented

The master branch (which is the one that requires PHP 7.1) already has iterable type hints where possible (it was done in #52), it's just not released yet.

  • 👍1