Idea: Make ast\Node->endLineno a declared property?

Question

Idea: Make ast\Node->endLineno a declared property?

TysonAndre opened this issue 3 years ago · 5 comments

Historically, ast\Node\Decl was a subclass of ast\Node, but in the latest AST parsing versions, everything is combined.

Alternately, php-ast could add an attributes array property to which a field endLineno could be added in AST versions exceeding some minimum value (and stop setting endLineno in older AST versions)

Answer 1 · 2021-11-19T15:07:22.000Z

Hm, maybe we can make it part of children for the few nodes that need it?

Answer 2 · 2021-11-19T15:10:45.000Z

That's probably simpler and more memory efficient. I guess target the next AST "major" version (current =90, next $version=100?)

We're already adding __declId to children

Answer 3 · 2021-11-19T15:12:13.000Z

Yeah, exactly.

Answer 4 · 2021-11-27T19:34:20.000Z

With #[AllowDynamicProperties], I guess we can just leave this as-is?

Answer 5 · 2022-08-08T12:46:29.000Z

With #[AllowDynamicProperties], I guess we can just leave this as-is?

I agree