nikolassv/bartib

Unicode symbols messing with "bartib continue" completion selection (in fish)

sbatial opened this issue · 2 comments

I will try to investigate further later but:
When I invoke shell completions on the "continue" command and I have a german umlaut in my description the description gets cut off there and the part after it is used as a project name.

So when I have an entry
<time> - <time> | Gut Ding | Wägt sich in Sicherheit
it shows up as (gt sich in ->W) in the completion selection.

System:

  • fedora 38
  • fish
    Version:
  • main branch (cargo install --git ...)

My findings so far: It has to do with the regex for the fish completion.
I do not fully get what the expression does but a pretty brute force way I have found would be to explicitly match for special characters as well.
So instead of [:ascii:] using ([:ascii:]|äüÄÜßẞëËöÖïÏ).

I really don't like this way... but if there's no better solution I'd probably put it in a variable to at least have that abomination only once (and to make sure all the patterns do match all the same characters).

I'd be happy to open a PR if there are no objections/better ideas.

Thank you for investigating this issue! The problem arose because the script tried to take only the relevant part of the strings. However, we do not need to do that on this point, because we trim the result anyway. I fixed in in 31a3e71 .