Formatter.php could be split

Question

Formatter.php could be split

nilportugues opened this issue 11 years ago · 2 comments

nilportugues commented 11 years ago

New classes can be created for the following concepts:

Indent
Parentheses
NewLine

This will reduce complexity.

Answer 1 · 2014-11-14T18:23:30.000Z

Can you explain this a little bit more?

Answer 2 · 2014-11-17T22:40:13.000Z

Sure. I'm aiming for single responsability.

I believe formatter is doing 3 different actions that happen at various levels when parsing the SQL. Moving them to another class can help finding (possible) errors and work on optimizations.