Server does not react to configuration changes
nickysn opened this issue · 0 comments
Changing the extension settings in VS Code should result in an update from the server. For example, enabling or disabling a certain inlay hint type (e.g. type hints, exception hints, parameter hints) should result in a refresh of the inlay hints.
Previously, this seemed to happen, but it turns out it was happening in a completely broken way. On configuration change, the VS Code client was sending a $/setTrace
notification, to indicate a potential change to the server log level. This notification was not supported by the server, which caused it to crash. On crash, VS Code restarts the server and then the new server initializes and picks up its new configuration. The inlay hints are refreshed and all looks well. Well, until you try to change too many configuration settings in a too short time, which causes the server restarts to exceed a certain limit and then VS code refuses to restart it anymore, so after that happens, you have to restart VS Code if you want to use the server.
After b6c640a, the server no longer crashes on $/setTrace
requests. However, it turns out, since the server isn't restarted, it doesn't pickup the new configuration. It is supposed to handle didChangeConfiguration
requests, but these don't seem to arrive for some unknown reason. There's supposedly a way to register for these notifications, but the way it's done seems to be poorly documented. :(