ning/async-http-client

Incorrect use of generics

Closed this issue · 4 comments

hiredman commented

looking through RequestBuilderBase.java I see a lot of (T)this where T is a generic. Java doesn't have reified generics so they cannot be used to cast like this. I am surprised the code even compiles.

a post on reified generics: http://gafter.blogspot.com/2006/11/reified-generics-for-java.html

jfarcand commented

Closing this issue as the library works fine now with Clojure

hiredman commented

I fail to see what incorrect use of generics has to do with clojure

jfarcand commented

I was under the impression this issue was filled and related to the clojure issue Hubert reported (he wasn't able to integrate properly). We did some change and now it seems to work. Sorry for the confusion.

hiredman commented

http://github.com/ning/async-http-client/commit/31e901c2eec2cf1b5e63e53a010a0c5b762b13d5#commitcomment-68228

I think while I was trying to assist him, I opened up the source code to take a look and noticed the attempts to use generics for runtime casting. At that point I believe I told him to find a library written by someone who knows java.