niveK77pur/ISM-Thermal-Model

Non-unique link names cause issues

Opened this issue · 0 comments

Having non-unique HSN names makes sense. Due to the hierarchical structure, one would assume that non-unique names for IFNs across different HSNs should be fine (which they appear to work fine).

Similarly, non-unique names for Links across different IFNs should be fine as well; but they cause issues along the following lines.

KeyError: 'Key <LinkName>-inversed already exists in HeatStorageNode'

Given the error message, the problem seems to stem from the inverse link generation in thermalmodel.py's _addInterfaceLinks() method.

It should be investigated why duplicate link names across different IFNs cause duplicate definition errors.