Muting a like can also mute a comment?
michaelyhma opened this issue · 6 comments
This is an AMAZING extension - thank you for building this, Noah! Will definitely be buying you a kofi!
To Reproduce
Steps to reproduce the behavior:
- Go to LinkedIn
- Go to the feed
- You'll see some posts where a contact has both liked AND commented on a post
- The post is therefore muted
Expected behavior
Using your extension, there's a toggle to mute Likes - so this is correct. However, I did NOT mute Comments, so would have expected to see Comment, even if Likes were muted
Environment (please complete the following information):
- Windows 10
- Chrome
- Should be the latest
I had the same experience and agree with the "expected behavior"
If they liked and commented they are gonna get caught by the like flag, and the current detectors are additive - meaning that it only takes one criteria to mute.
Understood! I guess the more specific feedback then would be:
"Would be perfect if the flags weren't additive" <3
I continue to use Link-Off, but the additive nature is muting, basically, everything (lol, also shows how LinkedIn Feed is a mess). Making the flag non-additive would make Link-Off super useful as a productivity/utility extension. Right now, it functions more as a "quiet"/"peaceful"/"zen"/"muting" extension.
Thank you for your consideration, Noah!
If you want to implement it, I'll gladly merge the PR - should be simple:
- The filtering is done here using keywords.some function.
- This functionality could be made by making replacing the .some with a reducer counting the matches, and treating is as true only if there is exactly one match