Fix Non-ASCII Character CRAN Note
Closed this issue · 2 comments
v2.0.0 passed all local checks without notes/etc. but the CRAN Package Check Results show two NOTEs (one for v2.0.0 and one for v1.3.1 -- preceding version). Notes only occur for v2.0.0 in r-devel-linux-x86_64-fedora-clang and v.1.3.1 in r-devel-linux-x86_64-fedora-gcc .
In both cases the note is as follows:
checking data for non-ASCII characters ... NOTE
Note: found 175 marked UTF-8 strings
I'm betting there's an easy way of flagging this but I'll need to look into it.
Edit
Re-checked the CRAN results and it looks like they're actually both from v2.0.0 so the issue is almost certainly in the new creatures dataset
Done!
Turns out the issue was both in the spell and creature data (interestingly not flagged in CRAN version that included the spell data though...). Managed to find/replace the offending characters in the dev/ scripts that create those tables from their respective GitHub repositories so this shouldn't be a problem going forward
Cautionary Word
The note about non-ASCII characters only shows up in the post-CRAN acceptance checks so I won't know for sure that I've resolved this until the next CRAN submission (which will be a bit probably). Reasonably confident that I've fixed this though so I'm closing this issue now