Why there is delay when opening the collapse ?

Question

Why there is delay when opening the collapse ?

Closed this issue 8 years ago · 6 comments

kopax commented 8 years ago

I am comparing react-collapse with bootstrap 4 and it's navbar collapse menu.

Why is the bootstrap 4 effect more fluid and is it possible to have the same ?

Answer 1 · 2017-02-13T11:41:00.000Z

Because it uses Spring animation. See https://github.com/chenglou/react-motion for details

Answer 2 · 2017-02-13T12:01:22.000Z

I have read the doc, is it possible for you to share the details ?

Also, when I click on the checkbox here it's perfectly fluid!

Answer 3 · 2017-02-13T12:08:40.000Z

So if http://nkbt.github.io/react-collapse/example/ is good, then delay in your app is something about your app, I reckon...

Answer 4 · 2017-02-13T12:09:29.000Z

Where can I find the example source code?

Answer 5 · 2017-02-13T12:55:55.000Z

I have remove a component with a Hudge jsx content under my test and then it went fluid again.
I guess I should move the effect to it's own component so it doesn't rerender the whole thing.

Answer 6 · 2017-02-13T13:32:48.000Z

yep, pretty usual problem when using react-motion. Need a proper sub-components caching with shouldComponentUpdate