An option to keep the node (not return null) when the height is zero

Question

An option to keep the node (not return null) when the height is zero

sompylasar opened this issue 9 years ago · 6 comments

This is required when applying CSS transitions (e.g. for background color).
When unmounted (null returned from render), the node loses its CSS state so when re-mounted, it gets fresh CSS state, and the transitions start over.

Answer 1 · 2015-12-12T07:14:07.000Z

I reckon that makes sense. Keen to PR?

Answer 2 · 2015-12-20T11:06:52.000Z

New opt-in feature to keep collapsed content keepCollapsedContent (defaults to false)

Answer 3 · 2015-12-20T11:14:00.000Z

Published as 1.6.0 https://github.com/nkbt/react-collapse/releases/tag/v1.6.0

Answer 4 · 2015-12-26T00:32:03.000Z

@nkbt Yay that's perfect! Thanks!

Answer 5 · 2015-12-26T01:02:35.000Z

Cheers! I had a fair amount of pain with this, but everything is solved now as far as I can test it. Check out the demo on gh-pages to see it in action :)

Answer 6 · 2017-03-08T21:35:22.000Z

Just a thought — any reason not to default this to true? Using this module for a client project (w/ Gatsby) and I noticed that before enabling this, there was some noticeable jumping in the animation right around when I assume the element was being destroyed. After I enabled this, the animation became super smooth.