nlpjoe/daguan-classify-2018

main_feature为all时,处理了2次word_embedding,没有处理char_embedding?

liuyaox opened this issue · 0 comments

word_embedding = Embedding(self.max_w_features, self.word_embed_size, weights=[self.word_embedding], trainable=False, name='word_embedding')

代码很好,学到很多~

有个疑问:这里应该是char_embedding吧?因为上面line21-24表示当main_feature为all时处理的是word_embedding,此时应该补充处理一下char_embedding吧?

同样的疑问也在textcnn_model.py中出现了,line37-40, line53-55