nlpub/pymystem3

Enable pipepline mode for pypy

lopuhin opened this issue · 5 comments

Right now pipeline mode is disabled for pypy, but it works at least for PyPy 2.5.1. Can it be turned on, either based on version number, or on feature detection? I can check what was wrong on pypy 1.9

Hello, we are currently busy addressing one issue related to windows platform. If you will be able to provide a pull request with a fix we it would be amazing. We have some basic tests with pypy on Trevis CI. Please check the version used there.

The problem was with PyPy <2.5.0. Due to an unknown bug the method select.select always exits with timeout. In pymystem3-0.1.4, I check version of PyPy and enable pipeline mode if PyPy >=2.5.1 is using. Thanks for the report!

Thank you! Sorry that I did not turn up to do it. Just had a quick look at that patch, I think that here master...neglectedvalue:master#diff-e14f3860ac8eded53e5a95872911d3bdR47 should also be a POSIX check, otherwise pipeline mode will be "on" for pypy on windows.

Yeah, right.

Commit deni64k@c2d58a3
Released as 0.1.5