nmattisson/HttpClient

Possible misinterpretation of empty http_request_t.hostname

Closed this issue · 0 comments

Hi Nils,

I might be wrong, but when I looked at this statement if (aRequest.hostname != NULL) in the implementation of HttpClient::request() I thought that some users might initialize the hostname field of the request this way myRequest.hostname = ""; and will assume that the request will be going against the given ip, but the above if-condition might be evaluatec TRUE and hence the request will not go against the ip but against an invalid hostname.
But I'm not too sure after having a second look at the implementation of the String class, so I might well be mistaken.

Cheers

Andy