Update starter file to calculate derived quantities in projection years

Question

Update starter file to calculate derived quantities in projection years

Closed this issue a year ago · 4 comments

CassidyPeterson-NOAA commented a year ago

Using the cod example, the starter file has a hard-wired maxyr_sdreport year = 101. This is copied to future model files, such that derived quantities are not calculated or reported in projection years.

Consider adding a check to convert starter maxyr_sdreport = -2 to resolve this issue.

This is a challenge when creating the new RatioMP for the FES MSE, which uses derived quantities in custom MP.

Answer 1 · 2024-03-12T23:07:32.000Z

Good point! I think modifying the input files directly would fix this: https://github.com/nmfs-fish-tools/SSMSE/tree/main/inst/extdata/models/cod

However=, do you think we should change this to -2 for the user automatically in all model cases? If so, we can change this setting in the starter file when the user calls run_SSMSE()

Answer 2 · 2024-03-14T17:25:10.000Z

Thanks, Kathryn! Yes, updating input file resolved the issue. I think it could be worth automating; I started to build some code but never got around to testing it.

Answer 3 · 2024-03-21T23:17:46.000Z

Thanks, did @nathanvaughan-NOAA address this? Feel free to close if so!

Answer 4 · 2024-03-22T06:04:07.000Z

Yep these fixes are now included in main with PR#184. Skyler tested and they were working.