nmwsharp/geometry-central

Forget to return result of Logarithmic Map on Vector Heat Method

liwind opened this issue · 1 comments

Forget to return result of Logarithmic Map on Vector Heat Method, when point on edge.

VertexData<Vector2> resultMap(mesh, Vector2::zero());
double tBlend = sourceP.tEdge;
for (Vertex v : mesh.vertices()) {
resultMap[v] = (1. - tBlend) * logmapTail[v] * tailRot + tBlend * logmapTip[v] * tipRot;
}
geom.unrequireHalfedgeVectorsInVertex();
break;

return resultMap; should add before break;(line 456) just like point on face(line 489)

Thank you for pointing this out! You are totally right, this looks like a bug.

I just pushed a quick fix in 2ceecc9. Feel free to reopen this issue if it seems like there are further problems.