noahsark769/cifilter.app

Layout broken in commit 11824e0e

Closed this issue ยท 2 comments

Unfortunately my iPhone doesn't support 13 yet. So I build the project for iOS12. Which the latest commit compatible to that version is 11824e0.

But I got this issue.

IMG_3055A76E6122-1

Is this worth to fix ๐Ÿ˜„? Can I make a PR for this?
Thanks in advance.

Hi @muizidn, so sorry for the long delay in getting back to you. Sure, I'd accept a pull request for those who want to build the project to a device which doesn't support iOS 13. I've created a branch called compatibility/ios-12, feel free to make a PR to that if you'd like. Unfortunately I don't think I'll be able to maintain this branch (won't get any bug fixes) but would be happy to have it around in case anyone wants to build the app in a working state for iOS 12. This is actually my fault for not bumping the version at the correct time.

Thanks!

Going to close this issue since I think the branch in the above comment should address the concern here. Feel free to reach out if I can help any more with this use case!