nobuhito/vscode.printcode

Question about Letter and Legal, Request for Tabloid

Opened this issue · 11 comments

scotthardwick commented

Hi Nobuhito,

Thanks so much for your work on this extension, it is very useful!

I have a question and a feature request:

  1. I notice that for the Letter and Legal paper types your mm measurements are different than I am used to:
    Letter 216mm x 279mm (I notice you use 280)
    Legal 216mm x 356mm (I notiec you use 357)
    Is there a reason for this?

  2. Could you add support for Tabloid?
    279mm x 432mm

Much Thanks!
Scott

janilahti commented

When I first added Letter I used 279 mm, but later when adding a bunch of other sizes, I borrowed the measurements from here https://github.com/cognitom/paper-css . Using millimeters is always an approximation with North American sizes. Do you see problems with the current values? Should I change millimeters to inches where appropriate (browsers/css should support that, too)?

I'll add Tabloid in the next PR soon.

edit: Funny. Now that I look code in paper-css, I see these kind of irregularities:

body.letter           .sheet { width: 216mm; height: 279mm }
body.letter.landscape .sheet { width: 280mm; height: 215mm }
body.legal            .sheet { width: 216mm; height: 356mm }
body.legal.landscape  .sheet { width: 357mm; height: 215mm }

There might be some reason for that...

scotthardwick commented

Jani,
Thanks so much for adding Tabloid!
I think keeping it as mm is fine.
I can't imagine what causes paper-css to alter the landscape version's sizing... interesting. I have google searched and not found any one else using those sizes, but they obviously must have had a use case that required it to be that way, just not sure what it might have been.

nobuhito commented

Which of the final answers is 279 or 280?

As for the Tabloid size, I do not want to increase the size any more, so I will not add it.

janilahti commented

Both of the sizes are only approximations, but the measures @scotthardwick suggested seem to be the ones normally used: https://en.wikipedia.org/wiki/Paper_size#North_American_paper_sizes .

nobuhito commented

So, shall we change it to 279 mm?

janilahti commented

Yes, Letter 279 mm and Legal 356 mm.

scotthardwick commented

As for the Tabloid size, I do not want to increase the size any more, so I will not add it.

Nobuhito is there any logical reason not to? It should only be a few lines of code for those of us who have access to tabloid printers?

nobuhito commented

Tabloid size is not available in any environment.

As in the picture there is not in the environment of Japan. However, there are many other sizes in Japan.

image

There are many other sizes. see https://www.princexml.com/doc/5.1/page-size/

nobuhito commented

Additional Information

We are currently implementing a function to add arbitrary CSS.

When it's complete

  1. Add CSS
  2. Open Print dialog
  3. Change paper size

It may be possible to print with the flow.
(I can not test it here)

Please wait a while.

nobuhito commented

@scotthardwick Fixed. Please update to version 3.0.0 and try it.
Please also try the above settings for tabloid.

nobuhito commented

@janilahti Thank you very much for your advice!!