which-key is not overriding description for key prefix
Closed this issue · 4 comments
i have something like that:
(general-define-key
:states '(normal visual emacs)
:keymaps 'org-mode-map
:prefix ","
"p" '(org-priority :which-key "org-priority")
)
few lines later:
(general-define-key
:states '(normal visual emacs)
:keymaps 'json-mode-map
:prefix ","
"p" '(json-pretty-print-buffer :which-key "pretty-print-buffer")
)
and few lines later:
(general-define-key
:states '(normal visual emacs)
:keymaps 'cperl-mode-map
:prefix ","
"p" '(:ignore t :which-key "plsense")
"ps" '(plsense-server-start :which-key "plsense-server-start")
)
the problem is that "plsense" description (the last one) in which key overrides everything : json-mode and also org-mode
how can i have correct description for "p" in each mode ?
i am talking ONLY about which-key
functionality is ok (wrong description, but correct functionality behind the description)
Pretty sure you want to use :major-modes. See the readme for more info.
excellent, it seems that it is working !!
thank you !
Currently i am testing this piece of code and at the moment no issues:
(general-define-key
:states '(normal visual emacs)
:keymaps 'org-mode-map
:major-modes 'org-mode
:prefix ","
"p" '(org-priority :which-key "org-priority")
"," '(org-ctrl-c-ctrl-c :which-key "org-ctrl-c-ctrl-c")
"A" '(org-attach :which-key "org-attach")
"i" '(:ignore t :which-key "insert")
"ib" '(org-insert-structure-template :which-key "org-insert-structure-template")
"id" '(org-insert-drawer :which-key "org-insert-drawer")
"ie" '(org-set-effort :which-key "org-set-effort")
"if" '(org-footnote-new :which-key "org-footnote-new")
"ih" '(org-insert-heading :which-key "org-insert-heading")
"iH" '(org-insert-heading-after-current :which-key "org-insert-heading-after-current")
"ii" '(org-insert-item :which-key "org-insert-item")
"il" '(org-insert-link :which-key "org-insert-link")
"in" '(org-add-note :which-key "org-add-note")
"ip" '(org-set-property :which-key "org-set-property")
"is" '(org-insert-subheading :which-key "org-insert-subheading")
"it" '(org-set-tags-command :which-key "org-set-tags-command")
"b" '(:ignore t :which-key "babel")
"bt" '(org-babel-tangle :which-key "org-babel-tangle")
)
(general-define-key
:states '(normal visual emacs)
:keymaps 'json-mode-map
:major-modes 'json-mode
:prefix ","
"p" '(json-pretty-print-buffer :which-key "pretty-print-buffer")
"b" '(json-mode-beautify :which-key "jm-beautify")
)
(general-define-key
:states '(normal visual emacs)
:keymaps 'cperl-mode-map
:major-modes 'cperl-mode
:prefix ","
"p" '(:ignore t :which-key "plsense")
"ps" '(plsense-server-start :which-key "plsense-server-start")
"k" '(:ignore t :which-key "comments, quotes")
"ki" '(perl-quote-single :which-key "quote-single")
"ko" '(perl-quote-double :which-key "quote-double")
"kl" '(comment-dwim :which-key "comment-dwim")
"kk" '(mark-defun :which-key "mark-defun")
"km" '(comment-region :which-key "comment-region")
"kn" '(uncomment-region :which-key "uncomment-region")
"kj" '(comment-line :which-key "comment-line")
"kt" '(comment-kill :which-key "comment-kill")
"m" '(:ignore t :which-key "modules")
"mm" '(find-perl-module :which-key "find-perl-module")
"=" '(:ignore t :which-key "format")
"==" '(perltidy-format :which-key "perltidy-format")
"=b" '(perltidy-format-buffer :which-key "perltidy-format-buffer")
"=f" '(perltidy-format-function :which-key "perltidy-format-function")
)
For these examples you could also use :major-modes t.
@noctuid ok thank, i will try
i am very happy with current status
btw. general.el is excellent package - this one of the reasons* why i started use pure emacs (not spacemacs). And it seems that i will no back to spacemacs. With packages like general.el (pure) emacs will have long live, because overall quality and user experience is very nice
so thank you again !
*the other one is use-package