node-red/node-red-nodes

node-red-node-ping in Triggered mode and Link nodes

jdotbdot opened this issue · 3 comments

jdotbdot commented

Which node are you reporting an issue on?

Node-red-node-ping

What are the steps to reproduce?

Place a Ping node (in Triggered mode so that it has an input as well as output) between link-in and link-out (return to calling node) nodes.
image

What happens?

The link-out node throws an error: "Missing return node information".

What do you expect to happen?

When the Ping node is set up in Triggered mode, any additional message properties such as msg.topic, msg._linkSource which arrive at the input should pass through to the output.

Please tell us about your environment:

  • Node-RED version: 3.0.2
  • node.js version: 16.17.0
  • npm version: 8.15.0
  • Platform/OS: Raspberry Pi/ RPiOS Bullseye
  • Browser: Firefox v105
dceejay commented

Well the node clearly specifies that the msg.topic will be set to the name of the host that was pinged... but yes, apart from that (and the payload) other properties should be preserved.

jdotbdot commented

Of course. I added msg.topic when creating this report without checking the help first.
I just wanted to highlight that msg.linkSource is not the only affected property.

dceejay commented

Fixed in version 0.3.2

  • 🎉1