node-strava/node-strava-v3

Incorrect typing for fractionReached()

futurus opened this issue · 2 comments

markstos commented

Whenever you know an exact change to make, submit a PR. It's the easiest for the volunteer maintainers and mostly likely to get the change you want done faster.

It's faster to click "merge" then then is to open a up a terminal, make sure the project has a fresh check out, re-create your change, write a commit message, push and close the issue.

Plus, you get credit in the commit history when you submit a PR, no matter now trivial the change.

So please submit a PR for this even though it's trivial. Thanks.

  • 👎1
firrae commented

My PR should correct this.