node-strava/node-strava-v3

Type definition issue with pushSubscription.

jreeter opened this issue · 1 comments

The type definition seems to export this interface:

export interface PushSubscriptionRoutes {
    list(args: any, done?: Callback): Promise<any>;
    create(args: any, done?: Callback): Promise<any>;
    delete(args: any, done?: Callback): Promise<any>;
}

However the pushSubscriptions.list implementation only takes a done arg:

pushSubscriptions.prototype.list = function (done) {
  var qs = this.client.getQS(['client_secret', 'client_id'], {
    client_secret: authenticator.getClientSecret(),
    client_id: authenticator.getClientId()
  })
  return this.client._requestHelper({
    headers: { Authorization: null },
    baseUrl: this.baseUrl,
    url: 'push_subscriptions?' + qs
  }, done)
}

The result is code that can't be compiled.

PR for issue: #89