README Logging in snippet should include the key "popupUri"

[dprat0821]

In the Logging in session of README.md, there is a snippet of popupLogin with the following statement:
session = await solid.auth.popupLogin({ popupUri });
Got blank popup page with it. After checking the source code I tried and found that it should be
session = await solid.auth.popupLogin({ popupUri: popupUri });

My envrionment: MacOS, Angular 7.0.4, Node: 8.12.9. OSX 10.14.2.

[RubenVerborgh]

Given that

{ popupUri }

is syntactic sugar for

{ popupUri: popupUri }

I strongly suspect the error is somewhere else. Can you verify?

[dprat0821]

I see. My original code was like this since it's a member variable in my code:
session = await solid.auth.popupLogin({ popupUri: this.popupUri });
Great to learn this syntax sugar. Still suggest maybe we can put a note there in case avoid people who don't know it spend hours troubleshooting :)

[RubenVerborgh]

Happy to hear it works 🙂