Sources in npm package are not standard JS (Flow)
theefer opened this issue · 3 comments
theefer commented
59accd0 is a great step toward making it easier to consume solid-auth-client as ES6 modules, but the sources in the npm distribution contain Flow type annotations, so they cannot be consumed easily without setting up extra preprocessing steps.
There might be value in exposing the Flow sources (though I myself usually tend to use TypeScript instead), but it'd be really helpful to have plain JavaScript sources while retaining the ES6 module syntax.
RubenVerborgh commented
Right, good point.
csarven commented
I have "solid-auth-client": "^2.2.9" in package.json. Is the following related to this issue:
$ npm run build
> dokieli@0.3.18 build /var/www/dokieli
> npm run build-dist
> dokieli@0.3.18 build-dist /var/www/dokieli
> webpack --progress --colors
Hash: 8ecc933d730a308859f4
Version: webpack 3.12.0
Time: 1749ms
Asset Size Chunks Chunk Names
do.js 2.45 MB 0 [emitted] [big] main
do.js.map 2.88 MB 0 [emitted] main
[4] (webpack)/buildin/global.js 509 bytes {0} [built]
[11] ./src/config.js 25 kB {0} [built]
[18] ./src/doc.js 4.61 kB {0} [built]
[19] ./src/uri.js 1.71 kB {0} [built]
[29] ./src/util.js 1.84 kB {0} [built]
[43] ./src/fetcher.js 15.3 kB {0} [built]
[44] ./src/graph.js 10.9 kB {0} [built]
[49] (webpack)/buildin/module.js 517 bytes {0} [built]
[67] ./src/storage.js 6.04 kB {0} [built]
[128] multi ./src/dokieli.js 28 bytes {0} [built]
[129] ./src/dokieli.js 299 kB {0} [built]
[130] ./src/inbox.js 6.43 kB {0} [built]
[131] ./src/auth.js 16.4 kB {0} [built]
[263] ./node_modules/@trust/webcrypto/src/algorithms 160 bytes {0} [optional] [built]
+ 269 hidden modules
WARNING in ./node_modules/@trust/webcrypto/src/algorithms/SupportedAlgorithms.js
84:22-60 Critical dependency: the request of a dependency is an expression
@ ./node_modules/@trust/webcrypto/src/algorithms/SupportedAlgorithms.js
@ ./node_modules/@trust/webcrypto/src/algorithms/index.js
@ ./node_modules/@trust/webcrypto/src/SubtleCrypto.js
@ ./node_modules/@trust/webcrypto/src/Crypto.js
@ ./node_modules/@trust/webcrypto/src/index.js
@ ./node_modules/@solid/oidc-rp/src/AuthenticationRequest.js
@ ./node_modules/@solid/oidc-rp/src/RelyingParty.js
@ ./node_modules/@solid/oidc-rp/src/index.js
@ ./node_modules/solid-auth-client/lib/webid-oidc.js
@ ./node_modules/solid-auth-client/lib/solid-auth-client.js
@ ./node_modules/solid-auth-client/lib/index.js
@ ./src/auth.js
@ ./src/dokieli.js
@ multi ./src/dokieli.js
otherwise I can create a new issue. Kind of a blocker for linkeddata/dokieli#253
RubenVerborgh commented