nodeca/navit

Should tests allow optional callback?

Closed this issue · 2 comments

Probably, saving .run() call is bad idea or over-engeneering. This also makes teardown flag a bit inconsistent.

I tend to remove this feature. If anyone has example why optional callbacks in tests should stay intact - let me know.

inca commented

Hi, Vitaly,

Huge thanks for a 💎 piece of software engineering!

👍 for removing callbacks in assertions: since I came from a bit of Nightmar'ish background, I tend to queue things up and then call run.