nodegui/nodegui-starter

Improve the gitignore for the deploy directory

danielo515 opened this issue · 1 comments

Hello.
I just noticed that I accidentally committed the deploy folder (I'm not using a template per se). I deleted it, tried to package and the package indeed fails. Then I come back to the documentation and saw that we are supposed to keep this directory.
But it will contain also build artifacts that I don't think we are supposed to keep.
Probably the right config for gitignore is

deploy/*
!deploy/config.json

Am I right?

Ok, now I see that we are supposed to keep the entire deploy directory and only ignore the build inside it.
This makes me think that it is not possible to build for the different platforms on CI, because we need a set of templates that are not present unless we commit them.