nodejs/build

FYI changed V8 CI configuration for BE platforms

richardlau opened this issue · 0 comments

richardlau commented

Forgot to record yesterday that I made a small change to the node-test-commit-v8-linux for Big Endian platforms (i.e. s390x).

While looking into a query from IBM's z/OS team (which in the end turned out to be because they were building d8 via Node.js' gyp build rather than V8's gn) and comparing what we were running here, I spotted that we had this in the job config:

if [ "X$DESTCPU" = "Xs390x" ]; then
 # ICU tests are disabled for BE platforms because the ICU included by V8 is le only
 # This is not an issue when we build in Node as we include the proper data files for BE but
 # it does mean that we need to build/test without ICU when running the v8 tests.
 DISABLE_V8_I18N_OPTION="DISABLE_V8_I18N=1"
fi

(also a similar conditional for Big Endian Linux on ppc64, which we haven't supported in Node.js for years). AFAICT this option isn't being set over in https://github.com/nodeshift/v8-build (used by the Red Hat team working on upstream V8 ppc64le and s390x) and I've verified in a copy of the job that the CI still passes on s390x without setting the option.

I'm fairly certain the "ICU included by V8 is le only" comment is historical and no longer true:

For reference (for those in Build who have access), the change was recorded in https://github.com/nodejs/jenkins-config-test/commit/3b580523276c26bcfc5744f41b2a168c0ef4316c.