http2 client: end event not emitted if no data listener registered

The http2 client will not emit end, given no data listener is registered, even if the server ends the response.

The following code calls req.on('end') just in the case req.on('data') is registered.

'use strict';
require('../common');
const assert = require('assert');
const http2 = require('http2');

const testResBody = 'other stuff!\n';

const server = http2.createServer((req, res) => {
  res.writeHead(200, {
    'Content-Type': 'text/plain'
  });
  res.end(testResBody);
});

server.listen(0, function() {
  const client = http2.connect(`http://localhost:${this.address().port}`);

  const headers = { ':path': '/' };
  const req = client.request(headers)
  req.setEncoding('utf8');

  // XXX: remove this and ` req.on('end')` is never called 
  let data = '';
  req.on('data', (d) => data += d);

  req.on('response', (headers) => {
    assert.ok('date' in headers,
              'Response headers contain a date.');
  });

  req.on('end', () => {
    server.close();
    process.exit();
  });
  req.end();
});

This is expected, as 'end' does not trigger the stream to flow. You should manually call resume(), add a on('data') or on('readable') event. This is part of streams, not http2.

thats interesting, as the http1 tests don't require it.

…

On Mon, May 15, 2017 at 1:34 PM, Matteo Collina ***@***.***> wrote: This is expected, as 'end' does not trigger the stream to flow. You should manually call resume(), add a on('data') or on('readable') event. This is part of streams, not http2. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#99 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AASMtvJ0DAoRy6TXkc-whN5Cy59ZZDXhks5r6DhfgaJpZM4NXPfv> .

Have a look at:

http2/test/parallel/test-http-date-header.js

Line 53 in 98e54b0

res.resume();

doh!

man thank you, I got a bit rusty!