Build failure when builddir contains spaces.

Question

Build failure when builddir contains spaces.

jasondavies opened this issue 13 years ago · 48 comments

Proposed Solution (lines 311+), from @trentm:

Old

argv.push('-Dnode_root_dir=' + nodeDir)
argv.push('-Dmodule_root_dir=' + process.cwd())

Fixed

Add:

function shellEscape(str) {
   return str.replace(/(["\s'$`\\])/g, '\\$1');
};

Change to:

argv.push('-Dnode_root_dir=' + shellEscape(nodeDir))
argv.push('-Dmodule_root_dir=' + shellEscape(process.cwd()))

Maybe I am missing something? My only confirmation that it is still not working is from the issue I made on another repository: nodegit/nodegit#123

Hope this can be resolved and merged soon!

Update:
Looks like the solution didn't completely work. Sorry for the false alarm 👎 .

Answer 7 · 2014-05-28T23:44:11.000Z

This is an Open Issue:

> fsevents@0.2.0 install /usr/local/lib/node_modules/karma/node_modules/chokidar/node_modules/fsevents
> node-gyp rebuild

make: *** No rule to make target `../../../../../../../../../../Volumes/Macintosh', needed by `Makefile'.  Stop.
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:267:23)
gyp ERR! stack     at ChildProcess.EventEmitter.emit (events.js:98:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:807:12)
gyp ERR! System Darwin 13.2.0
gyp ERR! command "node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /usr/local/lib/node_modules/karma/node_modules/chokidar/node_modules/fsevents
gyp ERR! node -v v0.10.28
gyp ERR! node-gyp -v v0.13.0
gyp ERR! not ok

workaround not working for me too

Answer 8 · 2014-08-01T21:12:37.000Z

Work-around (definitely OS X, probably unix*) until this is fixed:

create a new account, with no spaces in the folder name
log in as that user
install globally:

npm install -g PACKAGENAME

(this worked for me, to install zmq)

Answer 9 · 2015-01-23T20:54:31.000Z

Bump I guess? This still is an issue afaik.

Answer 10 · 2015-02-03T20:01:13.000Z

I am still having this issue here is a log output.

lwip@0.0.5 install /Users/michael dunton/projects/optimlol/node_modules/css-sprite/node_modules/lwip
> node-gyp rebuild

  CXX(target) Release/obj.target/lwip_decoder/src/decoder/init.o
clang: error: no such file or directory: 'dunton/.node-gyp/0.10.36/src'
clang: error: no such file or directory: 'dunton/.node-gyp/0.10.36/deps/uv/include'
clang: error: no such file or directory: 'dunton/.node-gyp/0.10.36/deps/v8/include'
make: *** [Release/obj.target/lwip_decoder/src/decoder/init.o] Error 1
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:267:23)
gyp ERR! stack     at ChildProcess.emit (events.js:98:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:820:12)
gyp ERR! System Darwin 14.1.0
gyp ERR! command "node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/michael dunton/projects/optimlol/node_modules/css-sprite/node_modules/lwip
gyp ERR! node -v v0.10.36
gyp ERR! node-gyp -v v1.0.2
gyp ERR! not ok

Answer 11 · 2015-03-30T13:09:02.000Z

yep, still an issue:

clang: error: no such file or directory: 'HD'
clang: error: no such file or directory: '2/Projects/bla/code/bla.js/node_modules/libxslt/node_modules/libxmljs/src'
clang: error: no such file or directory: 'HD'
clang: error: no such file or directory: '2/Projects/bla/code/bla.js/node_modules/libxslt/node_modules/libxmljs/vendor/libxml/include'
make: *** [Release/obj.target/libexslt/deps/libxslt/libexslt/common.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:269:23)
gyp ERR! stack     at ChildProcess.emit (events.js:110:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:1067:12)

Answer 12 · 2015-06-09T10:58:46.000Z

Any progress on this?

Answer 13 · 2015-06-29T14:47:03.000Z

👍 Not just a Windows issue: I'm trying to install an Atom plug-in that uses node-gyp as a dependency, and my ~/.atom is stored on my cloud, by symlinking it to my "Google Drive" folder. I can't exactly rename that folder to not have a space, as it's tied into Google Drive's software...

Seems like this is a case for delimiting strings using a null character rather that splitting at spaces, kind of like find . -print0 | xargs -0 ... does, no?

Answer 14 · 2015-07-15T16:45:18.000Z

Still an issue on Mac OS X 10.9.5.

Answer 15 · 2015-07-15T17:02:45.000Z

It's probably going to remain an issue, my recommendation is to either
create a separate account to install global modules as necessary, or go
through the steps of removing the space from your user account directory
name, steps outlined in the link below.

https://support.apple.com/en-us/HT201548

On Wed, Jul 15, 2015 at 9:45 AM, David Rhoderick notifications@github.com
wrote:

Still an issue on Mac OS X 10.9.5.

—
Reply to this email directly or view it on GitHub
#65 (comment)
.

Answer 16 · 2015-07-15T18:57:14.000Z

But why should it remain an issue, @kfancy? Plenty of CLI's support spaces in paths (and this is not just about the user root), this just seems like some missing escaping or quoting around a path parameter?

The global install works nicely, but it's a work-around.

Answer 17 · 2015-07-15T19:22:33.000Z

I'm not saying that it shouldn't be fixed, but given the longevity of the
bug obviously it's not a priority...
so, either fix your spaces in your name path, or do global. :-)

On Wed, Jul 15, 2015 at 11:57 AM, Philip Blyth notifications@github.com
wrote:

But why should it remain an issue, @kfancy https://github.com/kfancy?
Plenty of CLI's support spaces in paths (and this is not just about the
user root), this just seems like some missing escaping or quoting around a
path parameter?

The global install works nicely, but it's a work-around.

—
Reply to this email directly or view it on GitHub
#65 (comment)
.

Answer 18 · 2015-07-15T19:40:39.000Z

Good point... Hadn't noticed the 💀 date.

Answer 19 · 2015-07-17T21:35:33.000Z

I ran into a similar problem under chrisa/node-dtrace-provider#65, and my failure mode looks a lot like the issue that https://codereview.chromium.org/287393002/ was intended to fix.

Answer 20 · 2015-07-26T15:16:15.000Z

I have the same issue when I install webpack

Answer 21 · 2015-07-27T19:42:36.000Z

As a hack, you can create a SYMLINK for the target dir with no spaces. I tried at /Volumes/DIR_NAME_WITH_SPACES to /Volumes/DIR_WITH_NO_SPACES, then exported all ENV variables - HOME* for the newly defined value. This worked for me as my hard drive name contained spaces, changing from "Macintosh\ HD" to MacintoshHD via a symlink allowed webpack (node-gyp, fsevents,...) to install properly. YMMV

Answer 22 · 2015-12-01T02:33:29.000Z

This is still an issue!

Answer 23 · 2015-12-11T14:50:28.000Z

This seems like it should "simply" be a matter of finding an unquoted variable replacement in a shell command somewhere...... It's been an issue for 3 years now......

Answer 24 · 2015-12-31T10:50:49.000Z

This is still an issue!

Answer 25 · 2016-02-03T10:44:38.000Z

In the last 6 months I visited this issue twice.
So I documented the workaround that works for me.

My issue is that I have a hard-drive with the name Data HD.
And perhaps installing globally will work in most cases but not in mine.

To fix this: first create a symlink from your hard-drive-with-a-space-in-the-name

cd /Volumes/
ln -s 'Data HD' DataHD

The check your $HOME path:

echo $HOME
/Volumes/Data HD/Users/matthijs

Change $HOME (temporary?):

HOME=/Volumes/DataHD/Users/matthijs
export HOME
echo $HOME

Now use npm install and everything should work.

After you Quit the terminal, everything is set back to the original $HOME

Hope this saves someone time in the future

Answer 26 · 2016-05-15T13:44:37.000Z

Still an issue, even if it has a workaround it should be great if node-gyp could manage spaces in paths or send a warning about that :)

Answer 27 · 2016-05-20T09:41:48.000Z

Yes, this is still a problem, hacking with SYMLINK doesn't seem like a good solution.

Answer 28 · 2018-02-27T10:18:42.000Z

^ Rude.

Closing. It's been discussed in other issues and it's not going to change; gyp itself doesn't support blanks in paths.

Answer 29 · 2018-02-27T17:39:36.000Z

it's not going to change; gyp itself doesn't support blanks in paths.

If someone would like to patch gyp to handle spaces in paths that would be fine, but raising issues in node-gyp isn't helpful.

Answer 30 · 2018-02-27T20:37:09.000Z

The rabbit hole goes even deeper because not all tools that gyp calls out to handle them either.

Answer 31 · 2020-03-25T17:59:22.000Z

/ Building module: bindings, Completed: 0Attempting to build a module with a space in the path
See https://github.com/nodejs/node-gyp/issues/65#issuecomment-368820565 for reasons why this may not work
× Rebuild Failed

An unhandled error occurred inside electron-rebuild
'F:\Psitron' is not recognized as an internal or external command,
operable program or batch file.
'D' is not recognized as an internal or external command,
operable program or batch file.

Failed with exit code: 1

Error: 'F:\Psitron' is not recognized as an internal or external command,
operable program or batch file.
'D' is not recognized as an internal or external command,
operable program or batch file.

Failed with exit code: 1
    at SafeSubscriber._error (F:\Psitron Technologies\CONF DOC\R&D LoRa\BOM\Software\COM\electron-quick-start\node_modul
es\spawn-rx\lib\src\index.js:267:84)
    at SafeSubscriber.__tryOrUnsub (F:\Psitron Technologies\CONF DOC\R&D LoRa\BOM\Software\COM\electron-quick-start\node
_modules\rxjs\internal\Subscriber.js:205:16)
    at SafeSubscriber.error (F:\Psitron Technologies\CONF DOC\R&D LoRa\BOM\Software\COM\electron-quick-start\node_module
s\rxjs\internal\Subscriber.js:156:26)
    at Subscriber._error (F:\Psitron Technologies\CONF DOC\R&D LoRa\BOM\Software\COM\electron-quick-start\node_modules\r
xjs\internal\Subscriber.js:92:26)
    at Subscriber.error (F:\Psitron Technologies\CONF DOC\R&D LoRa\BOM\Software\COM\electron-quick-start\node_modules\rx
js\internal\Subscriber.js:72:18)
    at MapSubscriber.Subscriber._error (F:\Psitron Technologies\CONF DOC\R&D LoRa\BOM\Software\COM\electron-quick-start\
node_modules\rxjs\internal\Subscriber.js:92:26)
    at MapSubscriber.Subscriber.error (F:\Psitron Technologies\CONF DOC\R&D LoRa\BOM\Software\COM\electron-quick-start\n
ode_modules\rxjs\internal\Subscriber.js:72:18)
    at SafeSubscriber._next (F:\Psitron Technologies\CONF DOC\R&D LoRa\BOM\Software\COM\electron-quick-start\node_module
s\spawn-rx\lib\src\index.js:242:65)
    at SafeSubscriber.__tryOrUnsub (F:\Psitron Technologies\CONF DOC\R&D LoRa\BOM\Software\COM\electron-quick-start\node
_modules\rxjs\internal\Subscriber.js:205:16)
    at SafeSubscriber.next (F:\Psitron Technologies\CONF DOC\R&D LoRa\BOM\Software\COM\electron-quick-start\node_modules
\rxjs\internal\Subscriber.js:143:22)

_Hey guys,

I hope you all doing good, Thanks in advance. Really I tried 100 way to get rid of these errors. I couldn't.I need your advice._

Answer 32 · 2020-03-25T19:20:07.000Z

F:\Psitron Technologies\CONF DOC\R&D LoRa —>
F:\Psitron_Technologies\CONF_DOC\R&D_LoRa ?

Answer 33 · 2020-05-25T04:34:17.000Z

If you are using MacOS and your username contains space, such as: /Users/abc 1, I fix with:

Create a link file without space

sudo ln -s /Users/abc\ 1 /Users/abc

specify HOME env to install

HOME=/Users/abc npm install

Answer 34 · 2020-05-27T03:01:35.000Z

How can I fix this on a PC running Windows 10?

Answer 35 · 2021-02-19T06:32:38.000Z

× Rebuild Failed

An unhandled error occurred inside electron-rebuild
'C:\Users\Awaghade' is not recognized as an internal or external command,
operable program or batch file.

Failed with exit code: 1

Error: 'C:\Users\Awaghade' is not recognized as an internal or external command,
operable program or batch file.

Failed with exit code: 1
at SafeSubscriber._error (C:\Users\Awaghade Family\Downloads\mBlock-master (1)\mBlock-master\node_modules\spawn-rx\lib\src\index.js:267:84)
at SafeSubscriber.__tryOrUnsub (C:\Users\Awaghade Family\Downloads\mBlock-master (1)\mBlock-master\node_modules\rxjs\internal\Subscriber.js:205:16)
at SafeSubscriber.error (C:\Users\Awaghade Family\Downloads\mBlock-master (1)\mBlock-master\node_modules\rxjs\internal\Subscriber.js:156:26)
at Subscriber._error (C:\Users\Awaghade Family\Downloads\mBlock-master (1)\mBlock-master\node_modules\rxjs\internal\Subscriber.js:92:26)
at Subscriber.error (C:\Users\Awaghade Family\Downloads\mBlock-master (1)\mBlock-master\node_modules\rxjs\internal\Subscriber.js:72:18)
at MapSubscriber.Subscriber._error (C:\Users\Awaghade Family\Downloads\mBlock-master (1)\mBlock-master\node_modules\rxjs\internal\Subscriber.js:92:26)
at MapSubscriber.Subscriber.error (C:\Users\Awaghade Family\Downloads\mBlock-master (1)\mBlock-master\node_modules\rxjs\internal\Subscriber.js:72:18)
at SafeSubscriber._next (C:\Users\Awaghade Family\Downloads\mBlock-master (1)\mBlock-master\node_modules\spawn-rx\lib\src\index.js:242:65)
at SafeSubscriber.__tryOrUnsub (C:\Users\Awaghade Family\Downloads\mBlock-master (1)\mBlock-master\node_modules\rxjs\internal\Subscriber.js:205:16)
at SafeSubscriber.next (C:\Users\Awaghade Family\Downloads\mBlock-master (1)\mBlock-master\node_modules\rxjs\internal\Subscriber.js:143:22)
npm ERR! code ELIFECYCLE
npm ERR! errno 4294967295
npm ERR! mBlock@4.0.0 rebuild-serialport: electron-rebuild -f -w serialport
npm ERR! Exit status 4294967295
npm ERR!
npm ERR! Failed at the mBlock@4.0.0 rebuild-serialport script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR! C:\Users\Awaghade Family\AppData\Roaming\npm-cache_logs\2021-02-19T05_43_17_172Z-debug.log

i have the same issue . can anyone please help me out. i am using windows 10.

Answer 36 · 2021-07-16T12:53:05.000Z

i cannot use node-gyp on Windows 10 Pro because of spaces in folder names. I cannot change the folders names.
It happens for me when a python process is being spawned, but the passed arguments/parameters are not escaped.

Answer 37 · 2021-09-09T07:43:11.000Z

Same issue here, can't build on Big Sur when path contains spaces and I have no control on the folder name

Answer 38 · 2021-09-09T07:56:22.000Z

@jasondavies macOS workaround above #65 (comment)

Answer 39 · 2021-09-09T08:58:52.000Z

Thanks, that's not exactly the problem, I should have explained it better :
I never include spaces in my folder names, the problem comes from the /Mobile Documents/ (iCloud), it's located at
${HOME}/Library/ so setting the HOME variable won't do the trick. 🤷‍♂️

Answer 40 · 2021-09-09T09:17:23.000Z

Use backslash… HOME="/Mobile\ Documents/"

Answer 41 · 2021-09-09T09:23:18.000Z

Thanks Christian but that won't work.
The problem is not that node-gyp is trying to write temp files in a HOME path containing spaces that need escaping (what the HOME workaround actually fixes), the problem is when gyp is trying to access a file at a path containing spaces, doesn't matter if it's located in your home directory or not, it's not using the HOME variable at all when resolving this path.

Looks like there's nothing we can do about it as the problem comes from gyp itself, not node-gyp 😐

Answer 42 · 2022-05-25T05:39:59.000Z

Cannot believe this bug has existed for 10 years!!!
This still exists in v9.0.0 on MacOS

Answer 43 · 2022-06-16T09:04:12.000Z

Cannot believe this bug has existed for 10 years!!! This still exists in v9.0.0 on MacOS

When I move my projects to a mobile hard disk, I have a problem from 10 years ago

Answer 44 · 2022-06-27T19:09:29.000Z

By the way, I created a PR for this last year but it hasn't seen any movement: #2556

Answer 45 · 2022-06-28T02:37:34.000Z

By the way, I created a PR for this last year but it hasn't seen any movement: #2556

It looks so easy to fix.

Answer 46 · 2022-10-25T22:55:50.000Z

Can this be looked at, please?

Answer 47 · 2022-10-26T08:30:07.000Z

Can we have a GitHub Action that fails which demonstrates this problem? Which pull request should be reviewed?