nodejs/node

Regression in Jest with jsdom

cpojer opened this issue · 1 comments

  • Version: 7.3.0
  • Platform: mac os

Repro:

Two tests will fail on 7.3.0 that did not fail using 7.2.0. The concrete bug is when using --env=jsdom with Jest, console.log calls from a jsdom's vm context will not be printed any more for some reason. There is a PR in Jest to fix this: jestjs/jest#2457 but I'd like to first understand what regression in node caused this and whether this is a bug in node or an expected change.

Failed tests that expect "console.log" output to be present with the jsdom environment:
screen shot 2016-12-29 at 12 59 28 am

I'm bisecting to figure out what is going on here. Will post updates in the comment as edits

edit 1:

Looks like the commit that broke everything was 524f693

the original PR: #10227

/cc @bnoordhuis