Tests are not running anymore with C8 on node 18.11
w3nl opened this issue · 20 comments
Version
18.11.0
Platform
Darwin CLC02DRB4AMD6R 20.6.0 Darwin Kernel Version 20.6.0: Mon Aug 29 04:31:06 PDT 2022; root:xnu-7195.141.39~2/RELEASE_X86_64 x86_64
Subsystem
Mac OS 11.7, zsh 5.8
What steps will reproduce the bug?
When i run node --test src/ my tests are running.
When i use C8 c8 node --test src/, no tests are running, and no coverage.
And I see an error:
ERROR: Coverage for lines (0%) does not meet global threshold (90%)
zsh: segmentation fault c8 node --test src/
.nycrc
{
"all": true,
"include": [
"src/**/*.js"
],
"exclude": [
"**/*.test.js",
"**/__fixtures__/**"
],
"reporter": [
"text",
"text-summary",
"lcov",
"clover"
],
"check-coverage": true,
"watermarks": {
"lines": [
80,
95
],
"functions": [
80,
95
],
"branches": [
80,
95
],
"statements": [
80,
95
]
}
}Tested with node 18.10.0, and it was working
Has node 18.11.0 a breaking change or bug, or is it a C8 issue?
How often does it reproduce? Is there a required condition?
Only when combined with C8.
Doesnt work anymore since node 18.11.0
What is the expected behavior?
Like node 18.10.0, run the tests
What do you see instead?
ERROR: Coverage for lines (0%) does not meet global threshold (90%)
zsh: segmentation fault c8 node --test src/
Additional information
It looks like a breaking change in node 18.11.0, or is it a bug in c8?
Latest version of c8: 7.12
@Trott Here a test with a package in Github actions: https://github.com/hckrnews/objects/actions/runs/3255633842/jobs/5345156351
Segmentation fault (core dumped)
Error: Process completed with exit code 139.
@Trott Here a test with a package in Github actions:
That's running on Ubuntu Linux, but you reported macOS in the Platform information in the original post. Are you seeing the problem on macOS too or just on Linux?
On both platforms, on my local Mac and also in Linux in the GitHub action.
So it's not a local issue that only exists on my machine.
So it can be node, c8 or my config the project.
FYI Originally found in a repo that isnt public (of the company i work), but in this public package it's the same issue.
I add both version in the github action to show that the same code works on node 18.10 and not on node 18.11.
Here a test with and without c8: https://github.com/hckrnews/objects/actions/runs/3256091485/jobs/5346101809
node 18.10: works with and without c8
node 18.11: works without c8, but with c8 it failed, no tests are found
I can reproduce this on macOS:
const test = require('node:test');
test('test');npx c8 node --test test.js segfaults on v18.11.0 and main. If you don't use --test, the segfault does not occur. On v18.10.0, it works fine with and without --test.
It looks like there hasn't been a new version of c8 in a few months so this is almost certainly a node bug.
@nodejs/test_runner
I will take a look soon, I am with a temp computer so might take more time.
It might very well be related to #44520
More specifically, commenting out this if statement makes things work again.
this also reproduces when passing NODE_V8_COVERAGE
root@81d2d82220ad:/home/node# NODE_V8_COVERAGE=. node --test index.js
Segmentation fault (core dumped)
@cjihrig - the if you have mentioned is there to make SIGUSR1 only start an inspector server on the internal process (to avoid conflicting ports), so I will try tackling a bit to make NODE_V8_COVERAGE work without exposing a port, since what it seems to do is save files to the disk
@MoLow do you think you'll be able to fix it before the next release? Is there anything I can help with?
If we can't get it fixed, I think we should either revert the relevant changes, or reintroduce logic to make --test and --inspect incompatible. Regarding port conflicts - is there any reason not to use the approach the cluster module uses?
@cjihrig I'l try fixing before the next release, indeed.
if not - lets revert, sounds correct.
regarding the cluster module - I find the behavior there a little less friendly then #44520 - forcing a concurrency of 1 makes the inspector port be the port you specified, and in node:cluster you end up with open ports you did not specify
Is there anything I can help with?
@cjihrig If you want to take a look - My plan was to figure out how to start a v8 inspector agent that does not expose/run a websocket server and enable that when !options.allow_attaching_debugger && NODE_V8_COVERAGE,
@RafaelGSS any idea when a new release of node will be published? 18.12 doesn't had the fix
@RafaelGSS any idea when a new release of node will be published? 18.12 doesn't had the fix
Probably next week or the one after. We'll update nodejs/Release#737 according
Still not available in node 18.x, only in 19.x
Hope a new release of 18 will be soon, there was a release scheduled, but still no release deployed in december.
I have fixed my issue by moving to node:20 image in my github actions