nodeshift-archived/centos7-s2i-nodejs

Permission issues when running NODE_ENV=development and DEV_MODE=true

lholmquist opened this issue · 6 comments

i'm working on this nodeshift issue, nodeshift/nodeshift#208 to get buildConfig env vars, so i set NODE_ENV=development in my buildConfig and the build phase works fine with installing dev deps.

But during the pod deploy, i get permission issues now, when trying to load with nodemon(since DEV_MODE=true is set because of the development node env)

screen shot 2018-03-27 at 8 49 01 am

i thought by moving https://github.com/bucharest-gold/centos7-s2i-nodejs/blob/master/s2i/assemble#L61 down a little, it would fix it. but i'm either doing something wrong, which is very possible, or that wasn't the problem

lance commented

Related: #38

lance commented

@lholmquist I think this is what is biting us. I wonder if doing npm cache clean at the end of the assemble script might work. Is it easy enough to try that locally?

let me try.

I think i got something working here.

lholmquist@4a3b1e8

Basically, i moved the block of code that cleaned the npm cache and then fixed the write permissions down a little, so both a "production" and "development" environment will run it

lance commented

Fixed in: db8b853

lance commented

@lholmquist new images have been pushed for latest, 9.x and 8.x.