nodezoo/nodezoo-workshop

Zipkin Example

Opened this issue · 1 comments

I see @paolochiodi (and @rjrodger) implemented zipkin support and have since updated the ramanujan project.

My question is how would you implement this as part of nodezoo? I'm assuming you add zipkin tracing to each individual micro-service?

Github as an example:

Would this be as simple as including seneca-zipkin-tracer and then adding this around line 46?

Service.use('zipkin-tracer', { sampling: 1 });

Obviously this is a change from your Iteration 3: Measurement where you use influxdb, grafana, etc.

Hi Shaun.
I didn't touch nodezoo in a long time and I'm not entirely familiar with it but from what I see those steps unfortunately aren't enough.

seneca-zipkin-tracer require a recent seneca version, but from what I see nodezoo services are stuck with seneca 2.0.0.

Once they are up to date then yes, the steps you described should work