noflo/visualize

Errors with a simple net

Opened this issue · 7 comments

oleksandr commented

Example of a net:

P1(C1) OUT -> IN P2(C2)
P2 OUT -> IN P3(C3)

Result:

Invariant Violation: replaceState(...): Cannot update during an existing state transition (such as within render). This could potentially cause an infinite loop so it is forbidden.

forresto commented

I'll update visualize to use the new version of the-graph (custom element) and klay (autolayout) next week. This should fix these issues.

forresto commented

It looks like https://github.com/noflo/fbp doesn't parse P1 as a valid component name.

POne(C1) OUT -> IN PTwo(C2)
PTwo OUT -> IN PThree(C3)

works.

forresto commented

Actually,

P1(C1) OUT -> IN P2(C2)
P2() OUT -> IN P3(C3)

and

P1(C1) OUT -> IN p2(C2)
p2 OUT -> IN P3(C3)

work as well. @bergie something in the parser that keeps @oleksandr's second line (
P2 OUT -> IN P3(C3)
) from working ?

jpaulm commented

@oleksandr I just tried your original text, and got a message saying conn.src is undefined .

Added [0] after the OUT in the 2nd line, and got edges.forEach is not a function . !!!

bergie commented

Sounds like a bug in the .fbp parser. I'll transfer that example to a unit test a bit later

jpaulm commented

@bergie Should this be posted under https://github.com/noflo/fbp/issues ? If so, we could post it there and close this one.

oleksandr commented

@bergie In the Go's version of FBP parser using PEG I've noticed that order of expressions in the grammar matters :)