noherczeg/breadcrumb

Laravel 4 config file ignored

Closed this issue · 3 comments

spib commented

Hi,

I published the config file within laravel 4

php artisan config:publish noherczeg/breadcrumb

Made some changes, but the changes don't take effect. It looks to me like you aren't ever referencing the package config file.

I was able to make it work by adding the following line to BreadCrumb\Config.php around line 47 in the value() method

    if (!is_string($key)) {
            throw new \InvalidArgumentException("Invalid argument provided, string required!");
    }
    elseif(\Config::get('breadcrumb::' . $key, false) !== false) {
            return \Config::get('breadcrumb::' . $key, false);
    }
    // as before

Doing this and removing the namespace declaration from the generated config file worked for me but not sure what effect this would have on people using it outside of laravel

Greetings!

When I get home I'll test it out, and will merge your fix!

Thank you for your feedback!

Hey again!

First of all, I'm terribly sorry for the delay!

I just tried out your solution to the problem and it seems fine to me. I didn't even need to remove the namespace declaration yet it seems to work correctly. I don't have my ssh key with me now, so I'll push the fix when I get back home.

Thanks again for the response!

Fix has been applied!

Thanks spib!