noise-lab/netml

Last size in an IAT column for IAT_SIZE feature

Opened this issue · 1 comments

yuming-l2 commented

IAT_SIZE feature matrix will put the last size in the same column as IATs.

I guess it would be better to have iats_sizes.extend([sizes[j], iats[j]])

https://github.com/chicago-cdac/netml/blob/bae0e24240a7c82e8c63ef3a0e5f9fbd6d0eeff4/src/netml/pparser/parser.py#L413-L415

feamster commented

Thanks! Is your rationale just so that the the column names match the name "IAT_SIZE"? Trying to figure out if this is a bug or simply an enhancement. Thank you!