nolanlawson/emoji-picker-element

Emoji search returns no results for single letter queries

dumptyd opened this issue · 3 comments

dumptyd commented

This is a necessary feature when implementing something like github's emoji autocomplete dropdown. If there are performance concerns, you can keep this disabled by default and expose a way to modify MIN_SEARCH_TEXT_LENGTH.

nolanlawson commented

Yeah, I can see why you might want this to be configurable. Although it will bloat the size of the database, although I don't know by how much. In any case, it will need to be globally configured since it affects how data is written to IDB.

abdullah4a commented

@nolanlawson, I've fixed this issue as setting up min length 0 and changed the condition in picker if this change were needed then review PR here

nolanlawson commented

This is a necessary feature when implementing something like github's emoji autocomplete dropdown.

BTW it looks like GitHub's emoji autocomplete works with single-letter queries because it only renders a max of 5 emoji. emoji-picker-element does not have any kind of limit for the results, nor does it do any lazy/virtual rendering, hence the perf issue described here: #298 (comment)