nordtheme/nord

Consider more contrast for comments

josh-k-cb opened this issue · 1 comments

josh-k-cb commented

Description

The theme could benefit from more color contrast for comments in Typescript files, especially during diff.

Standard comment:
image

Diff comment:
image

I've personally applied these:

  "editor.tokenColorCustomizations": {
    "[Nord]": {
      "comments": "#81A1C1"
    }
  },
  "workbench.colorCustomizations": {
    "[Nord]": {
      "diffEditor.insertedTextBackground": "#5E81AC33"
    }
  }

to get this:

Standard comment:
image

Diff comment:
image

My solution might not be 'pure Nord' but I can read comments during diff, which is nice

Benefits

Readability

Possible Drawbacks

Objective opinion

crizant commented

This is exactly what i've been looking for, thanks!
Finally I can see comments in the git diff panel. I think this should be applied by default.