helm-docs write extra empty line
jlec opened this issue · 5 comments
I tried to find the right place in the code but wasn't able to determine what is causing it.
To reproduce, just run helm-docs against this repo. All the generated README.md have 2 empty lines.
Thanks, @jlec. I'll look further into your fix. What was the chart you tested against?
It doesn't look like a bug. Can you remember why did you end the README with 2 lines @Artus-LHIND ?
If it doesn't break any formatting or tests for me it's okay to change it. But I propose you a new fix @jlec.
If you run any standard formatter against a file with 2 trailing empty lines, it will be reformatted. Which in turn means, that validation of format will bail out.
Makes sense. Did you see my suggestions in the code? Once it is commit I'll merge the PR. Ok?