notandy/ympd

Does not properly encode '+' in url through browser

Kriegbaum opened this issue · 2 comments

When accessing an album through the library browser, ympd does not properly encode the + character into the url.

Example:
http://10.0.0.55:8080/#/browse/0/The%20Walkmen/Bows%20+%20Arrows
Is the URL generated when I attempt to access the walkmen album "Bows + Arrows"
This results in an empty tracklist

Manually punching in:
http://10.0.0.55:8080/#/browse/0/The%20Walkmen/Bows%20%2b%20Arrows
Displays a proper tracklist for the album

Wow, indeed. Interesting nobody ever noticed this before.
I've fixed this in my fork by using encodeURIComponent() instead of encodeURI(): 7b5496e

Haha, after opening this issue, I realized this project isnt really being maintained anymore and tried out myMpd. It's got a similar but slightly different URL encoding bug as well. I'll make a pull request on that one if I ever get the time to look at it