Update the branch policies for the repository
Closed this issue · 7 comments
toddysm commented
After reviewing the branch policies for the repository, it seems that the main
and release branches can benefit with more strict push and PR review policies. I would like to propose updating those as follows:
Note: @SteveLasker added checkboxes to indicate the current state
- Follow naming convention
release/<release-number>
for release branches. Examplerelease/rc.1
- Use the following rules for
main
andrelease/*
branches:- Require PR before merging
- Require 3 approvals
- Dismiss stale PR approvals when new commits are pushed
- Require review from Code Owners
- Require status checks to pass before merging
- Require conversation resolution before merging
- Require signed commits
- Do not allow bypass the above settings
Please add your comments and proposals for additional changes to this issue.
yizha1 commented
LGTM but IANAM
iamsamirzon commented
LGTM but IANAM
SteveLasker commented
Updated with checkboxes to indicate the current state as several of the rules were already in place.
vaninrao10 commented
LGTM but IANAM
iamsamirzon commented
LGTM but IANAM
priteshbandi commented
LGTM but IANAM
yizha1 commented
Closed as all polices enforced